Skip to content

Update osimC3D to deal with empty tables #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update osimC3D to deal with empty tables #2645

wants to merge 1 commit into from

Conversation

jimmyDunne
Copy link
Member

@jimmyDunne jimmyDunne commented Dec 17, 2019 •
edited by aseth1
Loading

Fixes issue seen in #2642

Brief summary of changes

  • Added flag and subsequent checks in functions to see if there are empty marker or force tables
  • updated indents in some sections

Testing I've completed

Tested using some c3ds with empty force or marker tables. Passed ctest, locally.

Looking for feedback on...

  • flags and calls look okay? Is there a better way of doing this?

CHANGELOG.md (choose one)

  • no need to update because this fixes a bug that we haven't see in the wild yet (but is expected)

This change is Reviewable

@jimmyDunne jimmyDunne changed the title Update to deal with empty tables Update osimC3D to deal with empty tables Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jimmyDunne